Skip to content

feat: Enable BSC for smart transactions #29747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 17, 2025
Merged

feat: Enable BSC for smart transactions #29747

merged 2 commits into from
Jan 17, 2025

Conversation

dan437
Copy link
Contributor

@dan437 dan437 commented Jan 16, 2025 •
edited
Loading

Description

Enables BSC for smart transactions and reduces status check time to 1s.

We can turn off BSC support for smart transactions remotely if needed.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Make sure smart transactions are enabled in Advanced Settings
  2. Be on the BNB Chain
  3. Submit a tx. It will be submitted as a smart transaction

Happy paths tested for Swaps, Send and dapp transactions, but this will require extensive testing before it goes to production.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-transactions Transactions team label Jan 16, 2025
@dan437 dan437 marked this pull request as draft January 16, 2025 15:58
@dan437 dan437 marked this pull request as ready for review January 17, 2025 13:14
klejeune
klejeune previously approved these changes Jan 17, 2025
View reviewed changes
antonydenyer
antonydenyer previously approved these changes Jan 17, 2025
View reviewed changes
@metamaskbot
Copy link
Collaborator

Builds ready [f44d86c]
Page Load Metrics (1794 ± 78 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30620881709356171
domContentLoaded15462033176014770
load15512089179416278
domInteractive257445168
backgroundConnect680292612
firstReactRender16103553115
getState470192110
initialActions01000
loadScripts10861541130812359
setupStore690182311
uiStartup175627412116303145
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 32 Bytes (0.00%)

@dan437 dan437 dismissed stale reviews from antonydenyer and klejeune via 89c7b31 January 17, 2025 13:52
@metamaskbot
Copy link
Collaborator

Builds ready [89c7b31]
Page Load Metrics (1748 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint25120011458586281
domContentLoaded15381936171813263
load15491999174813565
domInteractive198038157
backgroundConnect566282110
firstReactRender17101603215
getState591293115
initialActions01000
loadScripts10831464126812058
setupStore66515178
uiStartup174526942139286137
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 32 Bytes (0.00%)

@dan437 dan437 enabled auto-merge January 17, 2025 14:45
@dan437 dan437 added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 8038f4d Jan 17, 2025
72 checks passed
@dan437 dan437 deleted the stx-bsc branch January 17, 2025 16:19
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
@metamaskbot metamaskbot added the release-12.12.0 Issue or pull request that will be included in release 12.12.0 label Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonydenyer antonydenyer antonydenyer approved these changes

@infiniteflower infiniteflower infiniteflower approved these changes

@klejeune klejeune klejeune left review comments

Assignees
No one assigned
Labels
area-transactions release-12.12.0 Issue or pull request that will be included in release 12.12.0 team-transactions Transactions team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dan437 @metamaskbot @antonydenyer @klejeune @infiniteflower